Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft Pull Request about #10615 Copy cite command should respect preferences #10690

Closed
wants to merge 3 commits into from

Conversation

OvercloudX
Copy link

@OvercloudX OvercloudX commented Dec 4, 2023

Refs #10615

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

…nPreferences to CitationKeyGenerationPreferences.

2.Modify org.jabref.preferences.ExternalApplicationsPreferences#getCiteCommand to return a record. Creat and Name the record CitationCommandStringPreferences.

3.Tried to add a JUnit test
…nPreferences to CitationKeyGenerationPreferences.

2.Modify org.jabref.preferences.ExternalApplicationsPreferences#getCiteCommand to return a record. Creat and Name the record CitationCommandStringPreferences.

3.Tried to add a JUnit test
…nPreferences to CitationKeyGenerationPreferences.

2.Modify org.jabref.preferences.ExternalApplicationsPreferences#getCiteCommand to return a record. Creat and Name the record CitationCommandStringPreferences.

3.Tried to add a JUnit test
@koppor
Copy link
Member

koppor commented Dec 6, 2023

@OvercloudX I see a merge conflict here. Take this PR as an opportunity to learn how to resolve merge conflicts.

@koppor
Copy link
Member

koppor commented Dec 22, 2023

@OvercloudX Thank you for your first initiative. Since this was release-critical, we fixed it for ourselves (which was fast due to our 10+years developer experience). #10707

@koppor koppor closed this Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants